[
https://issues.apache.org/jira/browse/YARN-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199400#comment-15199400
]
Steve Loughran commented on YARN-4746:
--------------------------------------
looks reasonable.
Given all uses of the conversion in these pages now look like:
{code}
try {
id = ConverterUtils.toApplicationId(recordFactory, appId);
} catch (IllegalArgumentException e) {
throw new BadRequestException(e);
}
{code}
could we factor this out into something which always does this for the web UIs?
> yarn web services should convert parse failures of appId to 400
> ---------------------------------------------------------------
>
> Key: YARN-4746
> URL: https://issues.apache.org/jira/browse/YARN-4746
> Project: Hadoop YARN
> Issue Type: Bug
> Components: webapp
> Affects Versions: 2.8.0
> Reporter: Steve Loughran
> Priority: Minor
> Attachments: 0001-YARN-4746.patch, 0002-YARN-4746.patch
>
>
> I'm seeing somewhere in the WS API tests of mine an error with exception
> conversion of a bad app ID sent in as an argument to a GET. I know it's in
> ATS, but a scan of the core RM web services implies a same problem
> {{WebServices.parseApplicationId()}} uses {{ConverterUtils.toApplicationId}}
> to convert an argument; this throws IllegalArgumentException, which is then
> handled somewhere by jetty as a 500 error.
> In fact, it's a bad argument, which should be handled by returning a 400.
> This can be done by catching the raised argument and explicitly converting it
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
