[
https://issues.apache.org/jira/browse/YARN-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197795#comment-15197795
]
Arun Suresh commented on YARN-4829:
-----------------------------------
The patch looks mostly good. Thanks [~vvasudev]
Couplo minor nits:
* Maybe rename *Mi, Ti, Pi* to *Me, Te, Pe* or maybe replace eveything with *b
(Kb, Mb..) to signify binary ?
* Can we have a test case that converts between a binary to non-binary (K to
Ki) for eg. ?
> Add support for binary units
> ----------------------------
>
> Key: YARN-4829
> URL: https://issues.apache.org/jira/browse/YARN-4829
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-4829-YARN-3926.001.patch
>
>
> The units conversion util should have support for binary units.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
