[
https://issues.apache.org/jira/browse/YARN-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205478#comment-15205478
]
Junping Du commented on YARN-4820:
----------------------------------
Thanks [~vvasudev] for updating the patch!
The patch looks good in overall, just one comment in handling null charset case:
{code}
+ String reqEncoding = request.getCharacterEncoding();
+ if (reqEncoding == null || reqEncoding.isEmpty()) {
+ reqEncoding = "UTF-8";
+ }
{code}
>From HTTP1.1 protocol:
>https://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.7.1, if no charset
>parameter is provided by request, we should treat it as "ISO-8859-1", all
>other charsets need to claim explicitly in request.
Other looks good to me.
> ResourceManager web redirects in HA mode drops query parameters
> ---------------------------------------------------------------
>
> Key: YARN-4820
> URL: https://issues.apache.org/jira/browse/YARN-4820
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-4820.001.patch, YARN-4820.002.patch
>
>
> The RMWebAppFilter redirects http requests from the standby to the active.
> However it drops all the query parameters when it does the redirect.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
