[
https://issues.apache.org/jira/browse/YARN-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211282#comment-15211282
]
Jun Gong commented on YARN-4773:
--------------------------------
Thanks [~jlowe] for the review and comments.
{quote}
Why was stdout changed to sysout in the test? Seems unrelated.
{quote}
In the test case, *testSkipUnnecessaryNNOperationsForService* calls
*setRolledLogsIncludePattern("sysout")*, if generated container log is
"stdout", there will be no container logs that needs uploaded, then
*uploadedLogsInThisCycle* will always be false. In order to make both
*uploadedLogsInThisCycle* and *logAggregationInRolling* be true for some cases,
I change "stdout" to "sysout", then we could see cases that *cleanOldLogs* is
called.
Attached a new patch to address the first comment.
> Log aggregation performs extraneous filesystem operations when rolling log
> aggregation is disabled
> --------------------------------------------------------------------------------------------------
>
> Key: YARN-4773
> URL: https://issues.apache.org/jira/browse/YARN-4773
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.6.0
> Reporter: Jason Lowe
> Assignee: Jun Gong
> Priority: Minor
> Attachments: YARN-4773.01.patch, YARN-4773.02.patch
>
>
> I noticed when log aggregation occurs for an application the nodemanager is
> listing the application's log directory in HDFS. Apparently this is for
> removing old logs before uploading new ones. This is a wasteful operation
> when rolling log aggregation is disabled, since there will be no prior logs
> in HDFS -- aggregation only occurs once when rolling log aggregation is
> disabled.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
