[ 
https://issues.apache.org/jira/browse/YARN-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215256#comment-15215256
 ] 

Rohith Sharma K S commented on YARN-4607:
-----------------------------------------

Hi [~bibinchundatt]
Some  nits
# I think css modification is really required since it is not much affects the 
rendering. 
# Can you rename the method name {{WebPageUtils#requestsTableInit}} to 
{{WebPageUtils#resourceRequestsTableInit}} for readability. Similarly, keep the 
resourceRequest instead of requests in other places also for readability. 

> AppAttempt page TotalOutstandingResource Requests table support pagination
> --------------------------------------------------------------------------
>
>                 Key: YARN-4607
>                 URL: https://issues.apache.org/jira/browse/YARN-4607
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Minor
>         Attachments: 0001-YARN-4607.patch, 0002-YARN-4607.patch, Request with 
> Pagination.jpg, Request_without_pagination.jpg
>
>
> Simulate cluster with 10 racks with 100 nodes using sls and of we check the 
> table for Total Outstanding Resource Requests will consume complete page.
> Good to support pagination for the table



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to