[ 
https://issues.apache.org/jira/browse/YARN-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220700#comment-15220700
 ] 

Wangda Tan commented on YARN-4484:
----------------------------------

[~sunilg],

Thanks for working on this, approach looks good.

Not sure if I missed following test in your patch: a queue has >0 available 
resource from default partition and another partition, when container 
allocated/released, we should modify available resource from both partitions. 
Suggest to add the test if it isn't existed now.

> Available Resource calculation for a queue is not correct when used with 
> labels
> -------------------------------------------------------------------------------
>
>                 Key: YARN-4484
>                 URL: https://issues.apache.org/jira/browse/YARN-4484
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacity scheduler
>    Affects Versions: 2.7.1
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-4484.patch, 0002-YARN-4484.patch, 
> 0003-YARN-4484-v2.patch, 0003-YARN-4484.patch
>
>
> To calculate available resource for a queue, we have to get the total 
> resource allocated for all labels in queue compare to its usage. 
> Also address the comments given in 
> [YARN-4304-comments|https://issues.apache.org/jira/browse/YARN-4304?focusedCommentId=15064874&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15064874
>  ] given by [~leftnoteasy] for same.
> ClusterMetrics related issues will also get handled once we fix this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to