[
https://issues.apache.org/jira/browse/YARN-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221903#comment-15221903
]
Karthik Kambatla commented on YARN-4795:
----------------------------------------
Thanks for reporting and working on this, Daniel.
TestContainerMetrics part of the patch doesn't apply any more. One comment on
the patch: is it possible that flushOnPeriod and finished are both true? If
yes, looks like we would schedule another task unnecessarily. How about
updating the check from {{if (flushOnPeriod)}} to {{if (flushOnPeriod &&
!finished)}}? That mimics the previous version better too.
> ContainerMetrics drops records
> ------------------------------
>
> Key: YARN-4795
> URL: https://issues.apache.org/jira/browse/YARN-4795
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.9.0
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Attachments: YARN-4795.001.patch
>
>
> The metrics2 system was implemented to deal with persistent sources.
> {{ContainerMetrics}} is an ephemeral source, and so it causes problems.
> Specifically, the {{ContainerMetrics}} only reports metrics once after the
> container has been stopped. This behavior is a problem because the metrics2
> system can ask sources for reports that will be quietly dropped by the sinks
> that care. (It's a metrics2 feature, not a bug.) If that final report is
> silently dropped, it's lost, because the {{ContainerMetrics}} won't report
> anything else ever anymore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
