[
https://issues.apache.org/jira/browse/YARN-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228320#comment-15228320
]
Sunil G commented on YARN-4849:
-------------------------------
Thank you [~leftnoteasy] for the detailed cleaning up and mvn integration
activity. Overall it looks fine for me.. I could build this -Pyarn-ui. But i
havenot tested it, I will cover that as part of YARN-4515
Few comments from my end. Pls correct me if I am wrong.
1. In
{{hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/YarnUI2.md}}
We may need some change in below part
{noformat}
Try it
------
* Packaging and deploying Hadoop in this branch
* Modify `app/adapters/yarn-app.js`, change `host` to your YARN RM web
address
* If you running YARN RM in your localhost, you should install `npm
install -g corsproxy` and run `corsproxy` to avoid CORS errors. More details:
`https://www.npmjs.com/package/corsproxy`. And the `host` of
`app/adapters/yarn-app.js` should start with `localhost:1337`.
* Run `ember server`
* Visit your app at [http://localhost:4200](http://localhost:4200).
{noformat}
- {{Modify `app/adapters/yarn-app.js`, change `host` to}}, With YARN-4514, we
have a better way to handle this. We can refer to config.js instead.
- Run `ember server`. I think it is "ember serve".
2. In hadoop-yarn-ui/pom.xml, will "clean" target work? With clean, we expect
the generated source and war file to be removed, correct?
3. In src/main/resources/META-INF/LICENSE.txt, Apache TEZ ui is mentioned in
many places. Is it Apache YARN UI?
4. I may be wrong here Or could not find this info. In
hadoop-yarn-ui/src/main/webapp/tests, how this will be triggered by jenkins.
Pls help to share some information.
> [YARN-3368] cleanup code base, integrate web UI related build to mvn, and add
> licenses.
> ---------------------------------------------------------------------------------------
>
> Key: YARN-4849
> URL: https://issues.apache.org/jira/browse/YARN-4849
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-4849-YARN-3368.1.patch,
> YARN-4849-YARN-3368.2.patch, YARN-4849-YARN-3368.3.patch,
> YARN-4849-YARN-3368.4.patch, YARN-4849-YARN-3368.5.patch,
> YARN-4849-YARN-3368.6.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
