[
https://issues.apache.org/jira/browse/YARN-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228920#comment-15228920
]
Naganarasimha G R commented on YARN-3461:
-----------------------------------------
Thanks for the patch [~sjlee0]
few nits in the patch
# i am not sure why earlier code was trying to set these flags in
{{AMLauncher.setupTokens}} methods, would it be better to set it in the caller
{{createAMContainerLaunchContext}} *or* a seperate method for it *or* change
the method name to be more meaningful. Thoughts?
# i think instead of calling {{setFlowTags}} twice may be we can have
additional parameter indicating the default value along with pushing of
{{tag.split(":", 2)}} inside {{setFlowTags}}
> Consolidate flow name/version/run defaults
> ------------------------------------------
>
> Key: YARN-3461
> URL: https://issues.apache.org/jira/browse/YARN-3461
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Zhijie Shen
> Assignee: Sangjin Lee
> Labels: yarn-2928-1st-milestone
> Attachments: YARN-3461-YARN-2928.01.patch,
> YARN-3461-YARN-2928.02.patch
>
>
> In YARN-3391, it's not resolved what should be the defaults for flow
> name/version/run. Let's continue the discussion here and unblock YARN-3391
> from moving forward.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
