[
https://issues.apache.org/jira/browse/YARN-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sangjin Lee updated YARN-3461:
------------------------------
Attachment: YARN-3461-YARN-2928.03.patch
Posted patch v.3.
{quote}
i am not sure why earlier code was trying to set these flags in
AMLauncher.setupTokens methods, would it be better to set it in the caller
createAMContainerLaunchContext or a seperate method for it or change the method
name to be more meaningful. Thoughts?
{quote}
That's a good suggestion, and I made that change in the latest patch. I also
thought that the code was buried at an awkward place. I refactored the code out
to create a separate method ({{setFlowContext()}}).
{quote}
i think instead of calling setFlowTags twice may be we can have additional
parameter indicating the default value along with pushing of tag.split(":", 2)
inside setFlowTags
{quote}
We kind of need it in the form it's in. I know it seems somewhat awkward that
we call it twice for a given tag. However, note that the flow information may
not be present in the tags (that's why we need the defaults in the first
place!), in which case the inner {{setFlowTags()}} will not be invoked.
Another approach would be to call {{setFlowTags()}} with the default *after*
iterating over the tag, but that also adds some more code to handle it so it's
not clear if things become simpler.
The {{setFlowTags()}} method is pretty cheap (a simple {{Map.put()}} call
really), so I went for the simplest form of the implementation. Let me know if
that works.
> Consolidate flow name/version/run defaults
> ------------------------------------------
>
> Key: YARN-3461
> URL: https://issues.apache.org/jira/browse/YARN-3461
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Zhijie Shen
> Assignee: Sangjin Lee
> Labels: yarn-2928-1st-milestone
> Attachments: YARN-3461-YARN-2928.01.patch,
> YARN-3461-YARN-2928.02.patch, YARN-3461-YARN-2928.03.patch
>
>
> In YARN-3391, it's not resolved what should be the defaults for flow
> name/version/run. Let's continue the discussion here and unblock YARN-3391
> from moving forward.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
