[ 
https://issues.apache.org/jira/browse/YARN-4925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229472#comment-15229472
 ] 

Sunil G commented on YARN-4925:
-------------------------------

Thanks [~bibinchundatt].
Yes, NODE_LOCAL and OFF-SWITCH should not be set differently. So a change in 
ANY can reset other 2 types which is fine. I was just ensuring this point. No 
issue :)


> ContainerRequest in AMRMClient, application should be able to specify 
> nodes/racks together with nodeLabelExpression
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4925
>                 URL: https://issues.apache.org/jira/browse/YARN-4925
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>
> Currently with nodelabel AMRMClient will not be able to specify nodelabels 
> with Node/Rack requests.For application like spark NODE_LOCAL requests cannot 
> be asked with label expression.
> As per the check in  {{AMRMClientImpl#checkNodeLabelExpression}}
> {noformat}
>     // Don't allow specify node label against ANY request
>     if ((containerRequest.getRacks() != null && 
>         (!containerRequest.getRacks().isEmpty()))
>         || 
>         (containerRequest.getNodes() != null && 
>         (!containerRequest.getNodes().isEmpty()))) {
>       throw new InvalidContainerRequestException(
>           "Cannot specify node label with rack and node");
>     }
> {noformat}
> {{AppSchedulingInfo#updateResourceRequests}} we do reset of labels to that of 
> OFF-SWITCH. 
> The above check is not required for ContainerRequest ask /cc [~wangda] thank 
> you for confirming



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to