[
https://issues.apache.org/jira/browse/YARN-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230422#comment-15230422
]
Junping Du commented on YARN-4928:
----------------------------------
003 patch looks good in general. A NIT is we don't use below import pattern in
most practices.
{noformat}
+import org.apache.hadoop.fs.*;
{noformat}
CC [~gtCarrera9] who is author of related test case.
> Some yarn.server.timeline.* tests fail on Windows attempting to use a test
> root path containing a colon
> -------------------------------------------------------------------------------------------------------
>
> Key: YARN-4928
> URL: https://issues.apache.org/jira/browse/YARN-4928
> Project: Hadoop YARN
> Issue Type: Bug
> Components: test
> Affects Versions: 2.8.0
> Environment: OS: Windows Server 2012
> JDK: 1.7.0_79
> Reporter: Gergely Novák
> Assignee: Gergely Novák
> Priority: Minor
> Attachments: YARN-4928.001.patch, YARN-4928.002.patch,
> YARN-4928.003.patch
>
>
> yarn.server.timeline.TestEntityGroupFSTimelineStore.* and
> yarn.server.timeline.TestLogInfo.* fail on Windows, because they are
> attempting to use a test root paths like
> "/C:/hdp/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage/target/test-dir/TestLogInfo",
> which contains a ":" (after the Windows drive letter) and
> DFSUtil.isValidName() does not accept paths containing ":".
> This problem is identical to HDFS-6189, so I suggest to use the same
> approach: using "/tmp/..." as test root dir instead of
> System.getProperty("test.build.data", System.getProperty("java.io.tmpdir")).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
