[
https://issues.apache.org/jira/browse/YARN-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233085#comment-15233085
]
sandflee commented on YARN-4924:
--------------------------------
{quote}
I don't think removeDeprecatedKeys is an appropriate API in the state store.
It's too generic of a name, and it's being invoked in a very specific place
during recovery that may not be appropriate for other keys that may become
deprecated. IMHO this doesn't need to be in the API at all – the state store
implementation can clean up these keys as part of loading the application state.
{quote}
agree, and update the patch
> NM recovery race can lead to container not cleaned up
> -----------------------------------------------------
>
> Key: YARN-4924
> URL: https://issues.apache.org/jira/browse/YARN-4924
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 3.0.0, 2.7.2
> Reporter: Nathan Roberts
> Assignee: sandflee
> Attachments: YARN-4924.01.patch, YARN-4924.02.patch
>
>
> It's probably a small window but we observed a case where the NM crashed and
> then a container was not properly cleaned up during recovery.
> I will add details in first comment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
