[
https://issues.apache.org/jira/browse/YARN-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238624#comment-15238624
]
Allen Wittenauer commented on YARN-4734:
----------------------------------------
* Definitely need some clarification from ASF legal whether we can merge
licenses like that. My hunch is no, but IANAL.
* The dist and tmp directories should be inside target and not in the root of
the module. This makes a ton of other problems go away.
* Why is there a separate profile for this? What UI do I get if I don't build
with this profile? This also means the precommit hooks won't work until the
hadoop personality is modified (which means the above precommit testing is
mostly useless)
* Double check the license headers. At least one of 'em was using the old text.
* Why isn't YarnUI2.md's content in BUILDING.txt? Why does an *end user* care
about this information? Also, heads up to [~andrew.wang] since he is looking
to cut a release off of trunk relatively soon. This may have to get jettisoned
before the cut.
* The Apache RAT excludes files that don't or shouldn't exist (e.g., travis.yml)
* The Apache RAT excludes files that actually have a license.
* Why does "hadoop-yarn-ui/src/main/resources/META-INF/NOTICE.txt" mention Tez?
Why is this file even there?
* hadoop-yarn-ui/src/main/webapp/package.json should have it's version pulled
from maven. Let's not repeat past mistakes like we did with libhadoop.so
getting some random version number.
> Merge branch:YARN-3368 to trunk
> -------------------------------
>
> Key: YARN-4734
> URL: https://issues.apache.org/jira/browse/YARN-4734
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-4734.1.patch, YARN-4734.2.patch, YARN-4734.3.patch,
> YARN-4734.4.patch, YARN-4734.5.patch
>
>
> YARN-2928 branch is planned to merge back to trunk shortly, it depends on
> changes of YARN-3368. This JIRA is to track the merging task.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
