[ 
https://issues.apache.org/jira/browse/YARN-4947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240348#comment-15240348
 ] 

Sunil G commented on YARN-4947:
-------------------------------

[~bibinchundatt]

I think I was not very clear in explaining my point. Let me try again.

Test cases like {{TestRMWebServicesNodes}} has to override {{isDrained}} to 
return hardcoded boolean to continue. I agree with reason here, because event 
never drained  for these cases. So for any new test case similar to this, we 
always forced to override {{isDrained}}, which is not documented and easily to 
miss out. Pls correct me if I am wrong.

So I was thinking abt the real fix went in for  YARN-4893. Do we need to call 
{{drainEvents}} from MockRM, rather can we handle from each test case. Its  a 
choice and its fine either ways.:)

> Test timeout is happening for TestRMWebServicesNodes
> ----------------------------------------------------
>
>                 Key: YARN-4947
>                 URL: https://issues.apache.org/jira/browse/YARN-4947
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>         Attachments: 0001-YARN-4947.patch
>
>
> Testcase timeout for TestRMWebServicesNodes is happening after YARN-4893 
> [timeout|https://builds.apache.org/job/PreCommit-YARN-Build/11044/testReport/]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to