[
https://issues.apache.org/jira/browse/YARN-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241470#comment-15241470
]
sandflee commented on YARN-4924:
--------------------------------
Thanks [~jlowe], I had catch All exception in cleanupDeprecatedFinishedApps,
but let DBException escape seems not a good design. and in case others call
cleanupKeysWithPrefix in future, I will put createWriteBatch in try block.
{quote}
+ private void cleanupDeprecatedFinishedApps() {
+ try {
+ cleanupKeysWithPrefix(FINISHED_APPS_KEY_PREFIX);
+ } catch ({color:red}Exception{color} e) {
+ LOG.warn("cleanup keys with prefix " + FINISHED_APPS_KEY_PREFIX +
+ " from leveldb failed", e);
+ }
+ }
{quote}
> NM recovery race can lead to container not cleaned up
> -----------------------------------------------------
>
> Key: YARN-4924
> URL: https://issues.apache.org/jira/browse/YARN-4924
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 3.0.0, 2.7.2
> Reporter: Nathan Roberts
> Assignee: sandflee
> Attachments: YARN-4924.01.patch, YARN-4924.02.patch,
> YARN-4924.03.patch, YARN-4924.04.patch
>
>
> It's probably a small window but we observed a case where the NM crashed and
> then a container was not properly cleaned up during recovery.
> I will add details in first comment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
