[ 
https://issues.apache.org/jira/browse/YARN-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242229#comment-15242229
 ] 

Xuan Gong commented on YARN-4905:
---------------------------------

bq. It would be better if this function returned a formatted String instead of 
printing the data directly to the PrintStream

Looks like the other functions in LogsCLIHelps did the same thing, such as 
dumpAContainerLogs. So, let us keep it this way. And we could change it later 
together ?

bq. From the containerId we can get the node it ran on and we should let the 
user know which node it ran on.  in this case we should list all the containers 
that did run on the node and let the user know

Good points. But if the users want to know which node this container ran on,  
they can do "yarn logs --applicationId --ls --containerId", or if the users 
want to know which containers ran on this node, they can do "yarn logs 
--applicationId --ls --nodeAddress". 
So, to simplify, let us just output the error message, such as "The container 
couldn't be found on the node specified" ?

> Improve Yarn log Command line option to show log metadata
> ---------------------------------------------------------
>
>                 Key: YARN-4905
>                 URL: https://issues.apache.org/jira/browse/YARN-4905
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-4905.1.patch
>
>
> Improve the Yarn log commandline to have "ls" command which can list 
> containers for which we have logs, list files within each container, along 
> with file size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to