[ 
https://issues.apache.org/jira/browse/YARN-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bibin A Chundatt updated YARN-4967:
-----------------------------------
    Description: 
As per the discussion in YARN-3971 the we should be setting the service state 
to STARTED only after serviceStart() 
Currently {{AbstractService#start()}} is set
{noformat} 
     if (stateModel.enterState(STATE.STARTED) != STATE.STARTED) {
        try {
          startTime = System.currentTimeMillis();
          serviceStart();
..
 }
{noformat}
enterState sets the service state to proposed state. So in 
{{service.getServiceState}} in {{serviceStart()}} will return STARTED .

  was:
As per the discussion in YARN-3971 the we should be setting the service state 
to STARTED only after serviceStart() same for INiT too. Will be able to handle 
cases based on service state.
Thoughts?


> AbstractService should set state only after state change
> --------------------------------------------------------
>
>                 Key: YARN-4967
>                 URL: https://issues.apache.org/jira/browse/YARN-4967
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>
> As per the discussion in YARN-3971 the we should be setting the service state 
> to STARTED only after serviceStart() 
> Currently {{AbstractService#start()}} is set
> {noformat} 
>      if (stateModel.enterState(STATE.STARTED) != STATE.STARTED) {
>         try {
>           startTime = System.currentTimeMillis();
>           serviceStart();
> ..
>  }
> {noformat}
> enterState sets the service state to proposed state. So in 
> {{service.getServiceState}} in {{serviceStart()}} will return STARTED .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to