[
https://issues.apache.org/jira/browse/YARN-4957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246606#comment-15246606
]
Subru Krishnan commented on YARN-4957:
--------------------------------------
Thanks [~seanpo03] for working on this. I went through the patch & it looks
mostly good, just a few minor comments:
* Now that we have added the documentation for Reservation APIs (YARN-4468),
can you kindly update it as now we have changed the APIs. We also need to mark
this JIRA as API incompatible change so that it can be clearly called out in
the release.
* Can we mark *ApplicationClientProtocol::submitReservation* as _idempotent_
as now you have added handling of resubmissions requests.
* Typo in Javadoc of *ReservationSubmissionRequest::getReservationId*, should
be _Get_.
* *YarnClient::createReservation* need not have any arguments to align with
*YarnClient::createApplication*.
> Add getNewReservation in ApplicationClientProtocol
> --------------------------------------------------
>
> Key: YARN-4957
> URL: https://issues.apache.org/jira/browse/YARN-4957
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: applications, client, resourcemanager
> Affects Versions: 2.8.0
> Reporter: Subru Krishnan
> Assignee: Sean Po
> Attachments: YARN-4957.v0.patch
>
>
> Currently submitReservation returns a ReservationId if sucessful. This JIRA
> propose adding a getNewReservation in ApplicationClientProtocol for the
> following reasons:
> * Prevent zombie reservations in the face of client and/or network failures
> post submitReservation
> * Align reservation submission with application submission
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
