[
https://issues.apache.org/jira/browse/YARN-4807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248555#comment-15248555
]
Daniel Templeton commented on YARN-4807:
----------------------------------------
The signatures look better, but I'd still like to see the javadocs be a little
more specific, like:
{code}
* @throws InterruptedException if interrupted while waiting for the state
transition
{code}
> MockAM#waitForState sleep duration is too long
> ----------------------------------------------
>
> Key: YARN-4807
> URL: https://issues.apache.org/jira/browse/YARN-4807
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.8.0
> Reporter: Karthik Kambatla
> Assignee: Yufei Gu
> Labels: newbie
> Attachments: YARN-4807.001.patch, YARN-4807.002.patch,
> YARN-4807.003.patch, YARN-4807.004.patch, YARN-4807.005.patch,
> YARN-4807.006.patch, YARN-4807.007.patch, YARN-4807.008.patch,
> YARN-4807.009.patch, YARN-4807.010.patch, YARN-4807.011.patch
>
>
> MockAM#waitForState sleep duration (500 ms) is too long. Also, there is
> significant duplication with MockRM#waitForState.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
