[
https://issues.apache.org/jira/browse/YARN-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250453#comment-15250453
]
Bibin A Chundatt commented on YARN-4846:
----------------------------------------
[~leftnoteasy] IIUC its will still cause failure. Currently {{maxWaitTime}} is
0 and {{preemptionCandidates.get(id)}}=={{clock.getTime()}} in most of jenkins
run and
{noformat}
if (preemptionCandidates.get(id) + 2 * maxWaitTime < clock.getTime())
{noformat}
The second issue [~sunilg] mentioned is which happened in last test run
{noformat}
java.lang.NullPointerException: null
at
org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.PreemptableResourceCalculator.calculateResToObtainByPartitionForLeafQueues(PreemptableResourceCalculator.java:319)
at
org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.PreemptableResourceCalculator.computeIdealAllocation(PreemptableResourceCalculator.java:367)
at
org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.FifoCandidatesSelector.selectCandidates(FifoCandidatesSelector.java:66)
at
org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.ProportionalCapacityPreemptionPolicy.containerBasedPreemptOrKill(ProportionalCapacityPreemptionPolicy.java:317)
at
org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.ProportionalCapacityPreemptionPolicy.editSchedule(ProportionalCapacityPreemptionPolicy.java:190)
at
org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerPreemption.testPreemptionPolicyShouldRespectAlreadyMarkedKillableContainers(TestCapacitySchedulerPreemption.java:453)
{noformat}
For issue 2 One probable cause could be {{editSchedule()}} is getting invoked
by {{SchedulingMonitor}} at the same time {{editSchedule()}} is called from
testcase.
> Random failures for
> TestCapacitySchedulerPreemption#testPreemptionPolicyShouldRespectAlreadyMarkedKillableContainers
> --------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-4846
> URL: https://issues.apache.org/jira/browse/YARN-4846
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Attachments: 0001-YARN-4846.patch
>
>
> {noformat}
> java.lang.AssertionError: expected:<1> but was:<0>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at org.junit.Assert.assertEquals(Assert.java:542)
> at
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerPreemption.testPreemptionPolicyShouldRespectAlreadyMarkedKillableContainers(TestCapacitySchedulerPreemption.java:473)
> {noformat}
> https://builds.apache.org/job/PreCommit-YARN-Build/10826/testReport/org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity/TestCapacitySchedulerPreemption/testPreemptionPolicyShouldRespectAlreadyMarkedKillableContainers/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
