[
https://issues.apache.org/jira/browse/YARN-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250721#comment-15250721
]
Robert Kanter commented on YARN-4676:
-------------------------------------
Here is my final review feedback:
# The GracefulDecommision docs page isn't linked to from anywhere. You need to
add it to {{hadoop-project/src/site/site.xml}}, under the Yarn section
somewhere.
# While there's a lot of good detail in GracefulDecommision, parts of it are
too developer focused. The docs are meant more for users, who don't typically
need to know about implementation detals (e.g. DecommissioningNodeWatcher being
inside the ResourceTrackingService, or how the DecommissioningNodesWatcher
skips tracking application containers to be efficient, etc). Can you
remove/rephrase these parts with this in mind?
# Can you add a newline to the end of TestDecommissioningNodesWatcher.java?
We'll also see what Junping comes back with.
> Automatic and Asynchronous Decommissioning Nodes Status Tracking
> ----------------------------------------------------------------
>
> Key: YARN-4676
> URL: https://issues.apache.org/jira/browse/YARN-4676
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.8.0
> Reporter: Daniel Zhi
> Assignee: Daniel Zhi
> Labels: features
> Attachments: GracefulDecommissionYarnNode.pdf, YARN-4676.004.patch,
> YARN-4676.005.patch, YARN-4676.006.patch, YARN-4676.007.patch,
> YARN-4676.008.patch, YARN-4676.009.patch, YARN-4676.010.patch,
> YARN-4676.011.patch, YARN-4676.012.patch
>
>
> DecommissioningNodeWatcher inside ResourceTrackingService tracks
> DECOMMISSIONING nodes status automatically and asynchronously after
> client/admin made the graceful decommission request. It tracks
> DECOMMISSIONING nodes status to decide when, after all running containers on
> the node have completed, will be transitioned into DECOMMISSIONED state.
> NodesListManager detect and handle include and exclude list changes to kick
> out decommission or recommission as necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
