[
https://issues.apache.org/jira/browse/YARN-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256170#comment-15256170
]
Varun Vasudev commented on YARN-4966:
-------------------------------------
Thanks for the patch [~xgong]! I think the patch itself is ok - just a minor
change - change getAppState to appStateKnown.
However, it looks we need a re-factoring of the code in LogsCLI; the run
function in particular is becoming too big and too unmanageable. What do you
think? Should we file another JIRA about cleaning up the code?
> More improvement to get Container logs without specify nodeId
> -------------------------------------------------------------
>
> Key: YARN-4966
> URL: https://issues.apache.org/jira/browse/YARN-4966
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-4966.1.patch, YARN-4966.2.patch, YARN-4966.3.patch
>
>
> Currently, for the finished application, we can get the container logs
> without specify node id, but we need to enable
> yarn.timeline-service.generic-application-history.enabled.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)