[
https://issues.apache.org/jira/browse/YARN-4842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262919#comment-15262919
]
Vinod Kumar Vavilapalli commented on YARN-4842:
-----------------------------------------------
Thanks for taking this over, [~xgong]. I'll give credit to [~venkateshrin] in
the commit-log given that he worked on the first version of the patch.
Comments on the latest patch:
- The patch doesn't apply cleanly anymore. It is likely needed to be updated
after YARN-4905 too.
- Testcase
-- It looks like it is better to simply move all the new code into a new
testFetchApplictionLogsAsAnotherUser, we won't be duplicating much code even if
we do that
-- Should not be using pbimpls directly - for e.g ApplicationIdPBImpl,
ContainerIdPBImpl. There were similar usages not caused by your patch, let's
fix those too.
-- Fix comment for clarity - " // create the remote app dir for app2" ->
" // create the remote app dir for app2 but for a different user testUser"
-- Can you modify the test to add a scenario where the code guesses the
owner but cannot read files because he/she doesn't have file-system permissions?
> yarn logs command should not require the appOwner argument
> ----------------------------------------------------------
>
> Key: YARN-4842
> URL: https://issues.apache.org/jira/browse/YARN-4842
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Ram Venkatesh
> Assignee: Xuan Gong
> Attachments: YARN-4842.1.patch, YARN-4842.2.patch, YARN-4842.3.patch
>
>
> The yarn logs command is among the most common ways to troubleshoot yarn app
> failures, especially by an admin.
> Currently if you run the command as a user different from the job owner, the
> command will fail with a subtle message that it could not find the app under
> the running user's name. This can be confusing especially to new admins.
> We can figure out the job owner from the app report returned by the RM or the
> AHS, or, by looking for the app directory using a glob pattern, so in most
> cases this error can be avoided.
> Question - are there scenarios where users will still need to specify the
> -appOwner option?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
