[
https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Bokor updated YARN-4994:
-------------------------------
Attachment: YARN-4994.04.patch
Hi [~jzhuge],
I have done the recommended changes except for TestHadoopArchiveLogsRunner.
Here fs and yarnCluster use the same config object in different time. In
addition fs object is reused later. So it is not an obvious change.
bq. Could you rename the patches from HDFS-10287.* to YARN-4994.*?
The existing Hadoop QA comments are already pointing to HDFS-10287*. I uploaded
the new patch with correct name. Do you want me to rename the old ones?
> Use MiniYARNCluster with try-with-resources in tests
> ----------------------------------------------------
>
> Key: YARN-4994
> URL: https://issues.apache.org/jira/browse/YARN-4994
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test
> Affects Versions: 2.7.0
> Reporter: Andras Bokor
> Assignee: Andras Bokor
> Priority: Trivial
> Fix For: 2.7.0
>
> Attachments: HDFS-10287.01.patch, HDFS-10287.02.patch,
> HDFS-10287.03.patch, YARN-4994.04.patch
>
>
> In tests MiniYARNCluster is used with the following pattern:
> In try-catch block create a MiniYARNCluster instance and in finally block
> close it.
> [Try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html]
> is preferred since Java7 instead of the pattern above.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
