[ 
https://issues.apache.org/jira/browse/YARN-5000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276756#comment-15276756
 ] 

Wangda Tan commented on YARN-5000:
----------------------------------

A couple of comments about implementation: 

1) Instead of following logic:
{code}
75      if (url == undefined) {
76        url = "Not Available";
77      }
78      return url != "Not Available";
{code}

Can we just return {{url != undefined}} ?

2) yarn-app.js is still using dummy, could we change it to empty array 

3) A coupld of tabs found in your patch, could you double check it?

Will try this patch again after YARN-4515 get in 

> [YARN-3368] App attempt page is not loading when timeline server is not 
> started
> -------------------------------------------------------------------------------
>
>                 Key: YARN-5000
>                 URL: https://issues.apache.org/jira/browse/YARN-5000
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-5000.patch, 
> AppFinishedAndNoTimelineServer.png, AppRunningAndNoTimelineServer.png, 
> AppRunningAndNoTimelineServer_v2.png, YARN-5000-YARN-3368.1.patch, 
> YARN-5000-YARN-3368.2.patch, YARN-5000-YARN-3368.3.patch, 
> YARN-5000-YARN-3368.4.patch, YARN-5000-YARN-3368.5.patch, screenshot-1.png
>
>
> If timeline server is not started, app attempt page is not getting loaded.
> In new web-ui, yarnContainer route is tightly coupled with both RM and 
> Timeline server. And if one of server is not up, page will not load. If 
> timeline server is not up, container information from RM is to be displayed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to