[
https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278894#comment-15278894
]
John Zhuge commented on YARN-4994:
----------------------------------
+1 LGTM
javac warnings:
* YARN-5007 to fix the deprecated warnings
checkstyle warnings:
* Ignore the warning about
{{TestJobHistoryEventHandler#testTimelineEventHandling}} being longer than 150
lines. Leave it to the next poor soul. If you are really in the mood, you can
get it down to 150 by replacing {{tEntity.getEvents()}} with a var {{events}}.
Unit test failures:
* TestAMRMProxy: same failures on a clean stock build, so ignore.
* Other failures: unrelated to the changes.
> Use MiniYARNCluster with try-with-resources in tests
> ----------------------------------------------------
>
> Key: YARN-4994
> URL: https://issues.apache.org/jira/browse/YARN-4994
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test
> Affects Versions: 2.7.0
> Reporter: Andras Bokor
> Assignee: Andras Bokor
> Priority: Trivial
> Fix For: 2.7.0
>
> Attachments: HDFS-10287.01.patch, HDFS-10287.02.patch,
> HDFS-10287.03.patch, YARN-4994.04.patch, YARN-4994.05.patch,
> YARN-4994.06.patch, YARN-4994.07.patch
>
>
> In tests MiniYARNCluster is used with the following pattern:
> In try-catch block create a MiniYARNCluster instance and in finally block
> close it.
> [Try-with-resources|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html]
> is preferred since Java7 instead of the pattern above.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
