[ 
https://issues.apache.org/jira/browse/YARN-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15279571#comment-15279571
 ] 

Arun Suresh commented on YARN-5073:
-----------------------------------

Thanks for the patch [~kkaranasos] !!
Considering this is a minor refactoring of a non-public method.. running 
existing test-cases should be sufficient to validate that the fix does not 
break anything.
+1, Committing this shortly

> Refactor startContainerInternal() in ContainerManager to remove unused 
> parameter
> --------------------------------------------------------------------------------
>
>                 Key: YARN-5073
>                 URL: https://issues.apache.org/jira/browse/YARN-5073
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Konstantinos Karanasos
>            Assignee: Konstantinos Karanasos
>            Priority: Minor
>         Attachments: YARN-5073.001.patch
>
>
> The nmTokenIdentifier is no longer needed as a parameter in the 
> startContainerInternal() method of the ContainerManager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to