[ 
https://issues.apache.org/jira/browse/YARN-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283429#comment-15283429
 ] 

Arun Suresh commented on YARN-4738:
-----------------------------------

[~kkaranasos], Thanks for the updated patch..

don't think this would work though :
{noformat}
// Remove null containers from queuing context for killed queued containers.
    Iterator<Entry<ContainerTokenIdentifier, String>> killedQueuedContIter =
        context.getQueuingContext().getKilledQueuedContainers().entrySet().
            iterator();
    while (killedQueuedContIter.hasNext()) {
      if (removedNullContainers.contains(killedQueuedContIter.next())) {
        killedQueuedContIter.remove();
      }
    }
{noformat}

Since {{removedNullContainers}} is of type {{Set<ContainerId>}}

You should probably replace it with :
{noformat}
// Remove null containers from queuing context for killed queued containers.
    Iterator<ContainerTokenIdentifier> killedQueuedContIter =
        context.getQueuingContext().getKilledQueuedContainers().keySet().
            iterator();
    while (killedQueuedContIter.hasNext()) {
      if 
(removedNullContainers.contains(killedQueuedContIter.next().getContainerID())) {
        killedQueuedContIter.remove();
      }
    }
{noformat}

> Notify the RM about the status of OPPORTUNISTIC containers
> ----------------------------------------------------------
>
>                 Key: YARN-4738
>                 URL: https://issues.apache.org/jira/browse/YARN-4738
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Konstantinos Karanasos
>            Assignee: Konstantinos Karanasos
>         Attachments: YARN-4738-yarn-2877.001.patch, 
> YARN-4738-yarn-2877.002.patch, YARN-4738.002.patch, YARN-4738.003.patch, 
> YARN-4738.004.patch
>
>
> When an OPPORTUNISTIC container finishes its execution (either successfully 
> or because it failed/got killed), the RM needs to be notified.
> This way the AM also gets notified in turn about the successfully completed 
> tasks, as well as for rescheduling failed/killed tasks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to