[ 
https://issues.apache.org/jira/browse/YARN-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285720#comment-15285720
 ] 

Allen Wittenauer commented on YARN-4412:
----------------------------------------

bq.  i believe should be left as it is... since the class is always created and 
used within the NodeStatusUpdater and never generally shared.

Let's be absolutely crystal clear.  If a patch generates a findbugs warning 
then either:

a) The findbugs issue needs to get fixed with code

or

b) The findbugs issue needs to get excluded

Until one of those two things happens, the patch absolutely should not be 
committed.  There is no "just let it throw errors" option available.  This 
patch really should have been reverted until at least all of the findbugs 
issues were dealt with.  (... and soon as I finish the replacement for the 
nightly builds, issues like this won't be able to hide anymore.)

> Create ClusterMonitor to compute ordered list of preferred NMs for 
> OPPORTUNITIC containers
> ------------------------------------------------------------------------------------------
>
>                 Key: YARN-4412
>                 URL: https://issues.apache.org/jira/browse/YARN-4412
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>             Fix For: 3.0.0-alpha1
>
>         Attachments: YARN-4412-yarn-2877.v1.patch, 
> YARN-4412-yarn-2877.v2.patch, YARN-4412-yarn-2877.v3.patch, 
> YARN-4412-yarn-2877.v4.patch, YARN-4412-yarn-2877.v5.patch, 
> YARN-4412-yarn-2877.v6.patch, YARN-4412.007.patch, YARN-4412.008.patch, 
> YARN-4412.009.patch, YARN-4412.addendum-001.patch, YARN-4412.find-bugs.patch
>
>
> Introduce a Cluster Monitor that aggregates load information from individual 
> Node Managers and computes an ordered list of preferred Node managers to be 
> used as target Nodes for OPPORTUNISTIC container allocations. 
> This list can be pushed out to the Node Manager (specifically the AMRMProxy 
> running on the Node) via the Allocate Response. This will be used to make 
> local Scheduling decisions



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to