[
https://issues.apache.org/jira/browse/YARN-4837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinod Kumar Vavilapalli updated YARN-4837:
------------------------------------------
Attachment: YARN-4837-20160520.txt
Here's an updated patch with fixes and new test.
[~rohithsharma]
bq. One suggestion is can default value for threshold reduce to less than 50%?
bq. 1) Should we disable am-blacklisting by default?
I would like to tackle both of these as part of YARN-4685 so that others also
can see.
bq. 2. I am little bit confused with naming convention for blacklist with
placesBlacklist. And is there any plan to support blacklist racks in the future?
Yes, that's the idea. In other parts of the code, this list gets passed along
to filter both nodes and racks.
[~leftnoteasy]
Regarding renames, I've included the ones you pointed out. There are lot more
to be done, but I deliberately avoided them given the current size of the patch.
Addressed other comments.
bq. 6) ResourceBlacklistRequest -> (Resource)Place(ment)BlacklistRequest?
This is public API, cannot rename it now.
Created a new TestNodeBlacklistingOnAMFailures, moved existing tests from
TestAMRestart to this new class file.
testAMBlacklistPreventsRestartOnSameNodeForMinicluster() is a bogus test,
removed it.
[~sunilg]
bq. 1. yarn.resourcemanager.am-scheduling.node-blacklisting-enabled and
yarn.resourcemanager.am-scheduling.node-blacklisting-disable-threshold to be
added in yarn-default.xml.
Again, I deliberately deleted them for now. I'd like to discuss their
re-addition as part of the outcome for YARN-4685.
> User facing aspects of 'AM blacklisting' feature need fixing
> ------------------------------------------------------------
>
> Key: YARN-4837
> URL: https://issues.apache.org/jira/browse/YARN-4837
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Vinod Kumar Vavilapalli
> Priority: Critical
> Attachments: YARN-4837-20160515.txt, YARN-4837-20160520.txt
>
>
> Was reviewing the user-facing aspects that we are releasing as part of 2.8.0.
> Looking at the 'AM blacklisting feature', I see several things to be fixed
> before we release it in 2.8.0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
