[ 
https://issues.apache.org/jira/browse/YARN-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297442#comment-15297442
 ] 

Sangjin Lee commented on YARN-5018:
-----------------------------------

The point is taken.

Can we do this at least then? We can implement 
{{TimelineCollectorManager.postPut()}} to set the ready flag, and have 
subclasses of {{TimelineCollectorManager}} to call {{super.postPut()}} after 
doing their things. Or even better,

{code}
class TimelineCollectorManager {
  protected void doPostPut() {} // rename the old postPut()
  public void postPut() {
    doPostPut();
    // set the ready flag
  }
}

class RMTimelineCollectorManager {
  protected void doPostPut() {
    // do its thing
  }
}
...
{code}



> Online aggregation logic should not run immediately after collectors got 
> started
> --------------------------------------------------------------------------------
>
>                 Key: YARN-5018
>                 URL: https://issues.apache.org/jira/browse/YARN-5018
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Li Lu
>            Assignee: Li Lu
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-5018-YARN-2928.001.patch, 
> YARN-5018-YARN-2928.002.patch, YARN-5018-YARN-2928.003.patch, 
> YARN-5018-YARN-2928.004.patch
>
>
> In app level collector, we launch the aggregation logic immediately after the 
> collector got started. However, at this time, important context data has yet 
> to be published to the container. Also, if the aggregation result is empty, 
> we do not need to publish them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to