[
https://issues.apache.org/jira/browse/YARN-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298399#comment-15298399
]
Junping Du commented on YARN-4987:
----------------------------------
Thanks [~gtCarrera9] for updating the patch. Latest patch looks good in
overall. Just one question on below code:
{noformat}
+ if (activeStores > appCacheMaxSize * 2) {
+ LOG.debug("Force release cache {} since {} stores are active",
+ groupId, activeStores);
+ cacheItem.forceRelease();
+ }
{noformat}
Do we have special reason when setting bar of force release cache item to be
twice as {{appCacheMaxSize}}? Shouldn't it be equal to appCacheMaxSize or
something configurable?
> Read cache concurrency issue between read and evict in EntityGroupFS timeline
> store
> ------------------------------------------------------------------------------------
>
> Key: YARN-4987
> URL: https://issues.apache.org/jira/browse/YARN-4987
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Li Lu
> Assignee: Li Lu
> Priority: Critical
> Attachments: YARN-4987-trunk.001.patch, YARN-4987-trunk.002.patch,
> YARN-4987-trunk.003.patch
>
>
> To handle concurrency issues, key value based timeline storage may return
> null on reads that are concurrent to service stop. This is actually caused by
> a concurrency issue between cache reads and evicts. Specifically, if the
> storage is being read when it gets evicted, the storage may turn into null.
> EntityGroupFS timeline store needs to handle this case gracefully.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
