[ 
https://issues.apache.org/jira/browse/YARN-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298567#comment-15298567
 ] 

Arun Suresh commented on YARN-5082:
-----------------------------------

Nice catch [~sandflee], In general, i think the patch looks ok. Minor nits:
# Any reason you changed the name of the priority variable ?
# I am guessing you changed the argument of isReservable from 'container' to 
'capability' since you have delayed creating the container until the reserve 
method.. can you confirm ?
# Maybe good to have a test case to verify that new containers are not 
generated.


> ContainerId rapidly increased in fair scheduler if the num of  node app 
> reserved reached the limit
> --------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5082
>                 URL: https://issues.apache.org/jira/browse/YARN-5082
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: sandflee
>            Assignee: sandflee
>         Attachments: YARN-5082.01.patch, YARN-5082.02.patch
>
>
> see many logs like 
> {quote}
> 16/05/14 01:07:58 DEBUG fair.FSAppAttempt: Not creating reservation as 
> container container_1463159225729_0002_01_000003 is not reservable
> 16/05/14 01:07:58 DEBUG fair.FSAppAttempt: Not creating reservation as 
> container container_1463159225729_0002_01_000004 is not reservable
> 16/05/14 01:07:58 DEBUG fair.FSAppAttempt: Not creating reservation as 
> container container_1463159225729_0002_01_000005 is not reservable
> 16/05/14 01:07:58 DEBUG fair.FSAppAttempt: Not creating reservation as 
> container container_1463159225729_0002_01_000006 is not reservable
> 16/05/14 01:07:58 DEBUG fair.FSAppAttempt: Not creating reservation as 
> container container_1463159225729_0002_01_000007 is not reservable
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to