[
https://issues.apache.org/jira/browse/YARN-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300894#comment-15300894
]
Jian He commented on YARN-1942:
-------------------------------
looks good overall, few comments
- No need to create a new API ? change the existing API from int to long, as
long can accept int.
{code}
@Public
@Unstable
public static ContainerId newContainerId(ApplicationAttemptId appAttemptId,
long containerId) {
}
{code}
- comment does not match code
{code}
/*
* This method is deprecated, use {@link ApplicationId#toString()} instead.
*/
@Public
@Deprecated
public static ApplicationId toApplicationId(
String appIdStr) {
return ApplicationId.fromString(appIdStr);
}
{code}
> Many of ConverterUtils methods need to have public interfaces
> -------------------------------------------------------------
>
> Key: YARN-1942
> URL: https://issues.apache.org/jira/browse/YARN-1942
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api
> Affects Versions: 2.4.0
> Reporter: Thomas Graves
> Assignee: Wangda Tan
> Priority: Critical
> Attachments: YARN-1942.1.patch, YARN-1942.10.patch,
> YARN-1942.2.patch, YARN-1942.3.patch, YARN-1942.4.patch, YARN-1942.5.patch,
> YARN-1942.6.patch, YARN-1942.8.patch, YARN-1942.9.patch
>
>
> ConverterUtils has a bunch of functions that are useful to application
> masters. It should either be made public or we make some of the utilities
> in it public or we provide other external apis for application masters to
> use. Note that distributedshell and MR are both using these interfaces.
> For instance the main use case I see right now is for getting the application
> attempt id within the appmaster:
> String containerIdStr =
> System.getenv(Environment.CONTAINER_ID.name());
> ConverterUtils.toContainerId
> ContainerId containerId = ConverterUtils.toContainerId(containerIdStr);
> ApplicationAttemptId applicationAttemptId =
> containerId.getApplicationAttemptId();
> I don't see any other way for the application master to get this information.
> If there is please let me know.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
