[
https://issues.apache.org/jira/browse/YARN-5127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301512#comment-15301512
]
Arun Suresh commented on YARN-5127:
-----------------------------------
Thanks for the patch [~hrsharma]
It looks good generally.. Couple of comments:
# in *yarn_protos.proto*, set the default value of *execution_type* to
GUARANTEED
# in {{ContainerPBImpl}} instead of adding convertTo/FromProto methods, check
if {{ProtoUtils}} already has the converter, if not, maybe add it there and
call the {{ProtoUtils.convert..}} method
# In {{BuilderUtils}}, add another backwards compatible {{newInstance()}}
without the ExecutionType argument with default executionType set to
{{GUARANTEED}}
# Once you do the above, you can revert the the changes in {{FSAppAttempt}} and
{{RegularContainerAllocator}}, Only the {{OpportunisticContainerAllocator}}
should use the new method.
# In {{TestRMContainerImpl}}, you can revert the changes to the import list.
> Expose ExecutionType in Container api record
> --------------------------------------------
>
> Key: YARN-5127
> URL: https://issues.apache.org/jira/browse/YARN-5127
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Hitesh Sharma
> Attachments: YARN-5127.002.patch, YARN-5127.v1.patch
>
>
> Currently the ExecutionType of the Container returned as a response to the
> allocate call is contained in the {{ContinerTokenIdentifier}} which is
> encoded into the ContainerToken.
> Unfortunately, the client would need to decode the returned token to access
> the ContainerTokenIdentifier, which probably should not be allowed.
> This JIRA proposes to add a {{getExecutionType()}} method in the container
> record.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
