[
https://issues.apache.org/jira/browse/YARN-5124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arun Suresh updated YARN-5124:
------------------------------
Attachment: YARN-5124.005.patch
Updating patch to fix the javadoc and some of the checkstyle warnings.
Some of the checkstyles are unfixable. For eg:
{noformat}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java:326:
ResourceRequestInfo>>> rre : remoteRequestsTable.values()) {:
'ResourceRequestInfo' have incorrect indentation level 14, expected level
should be 19.
{noformat}
If I fix the above, the line becomes too long..
And then there are checkstyles warnings like:
{noformat}
@Override:3: Method length is 169 lines (max allowed is 150).
{noformat}
The patch itself adds 2 lines, and refactoring that method is beyond the scope
of this patch
I feel it isnt worth fixing checkstyle warnings that ask for addition of
setters and getters to fields, especially when existing fields in the class do
not have them.
> Modify AMRMClient to set the ExecutionType in the ResourceRequest
> -----------------------------------------------------------------
>
> Key: YARN-5124
> URL: https://issues.apache.org/jira/browse/YARN-5124
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: YARN-5124.001.patch, YARN-5124.002.patch,
> YARN-5124.003.patch, YARN-5124.004.patch, YARN-5124.005.patch
>
>
> Currently the {{ContainerRequest}} allows the AM to set the {{ExecutionType}}
> in the AMRMClient, but it is not being set in the actual {{ResourceRequest}}
> that is sent to the RM
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
