[
https://issues.apache.org/jira/browse/YARN-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307032#comment-15307032
]
Joep Rottinghuis commented on YARN-5105:
----------------------------------------
[~varun_saxena] I like the very clear description of @param metricsLimit.
It works almost the same as limit (in so far that the default is returned for
negative values).
One difference is that the default limit is 100 whereas the metrics limit is 1.
Also, for limit a value of 0 is allowed, whereas for metrics limit 0 is
considered to be 1.
I'm not sure if a limit of 0 makes sense (or whether such fields should simply
not be returned?). Perhaps somebody will want to make a call and get no data
back, just to test if connectivity works.
Whether or not we allow 0, I think it might be good to document the behavior of
the limit parameter as clearly as you've done metricsLimit, otherwise people
might have an expectation that they work the same (which they almost do).
Note that a PageFilter (used for limit) does appear to allow 0, whereas a
Get#setMaxVersions does not allow 0 and will throw an IOException.
Other than that nit the patch looks good to me.
> entire time series is returned for YARN container system metrics (CPU and
> memory)
> ---------------------------------------------------------------------------------
>
> Key: YARN-5105
> URL: https://issues.apache.org/jira/browse/YARN-5105
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Sangjin Lee
> Assignee: Varun Saxena
> Labels: yarn-2928-1st-milestone
> Attachments: YARN-5105-YARN-2928.01.patch,
> YARN-5105-YARN-2928.02.patch, YARN-5105-YARN-2928.03.patch,
> YARN-5105-YARN-2928.04.patch
>
>
> I see that the entire time series of the CPU and memory metrics are returned
> for the YARN containers REST query. This has a potential of bloating the
> output big time.
> {noformat}
> "metrics": [
> {
> "type": "TIME_SERIES",
> "id": "MEMORY",
> "values":
> {
> "1463518173363": 407539712,
> "1463518170347": 407539712,
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
