[
https://issues.apache.org/jira/browse/YARN-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Vasudev updated YARN-4830:
--------------------------------
Attachment: YARN-4830-YARN-3926.003.patch
Uploaded a new patch to address [~asuresh]'s comments.
bq. Do we need LOG in ResourcePBImpl ? or is it just for testing ?
I'm currently printing a warning when some one tries to add an unknown resource
type.
bq. ResourceUtils::addResourcesFileToConf : add a finally to close the input
stream
Fixed.
bq. check/addMandatoryResourceTypes : My opinion is we should keep it as
check/addMandatoryResources since we are actually adding the resource values.
The Type in to name means we are adding a new type of resource
Hmm - I really wanted to differentiate between the RM which deals with resource
types and the NM which deals with resources. I have no particular preference;
changed to address your comment.
bq. Can’t nodeLock be replaced with a volatile boolean ?
You can't lock on a boolean. If we ever need to synchronize, it's easier to
have an object.
bq. Thinking if we really need nodeLock at all.. can’t we perform the null
check and synchronized assignment on readOnlyNodeResources itself ? or am I
missing something ?
That would mean making readOnlyNodeResources volatile and losing out on the
optimizations that the JVM carries out on non-volatile objects.
> Add support for resource types in the nodemanager
> -------------------------------------------------
>
> Key: YARN-4830
> URL: https://issues.apache.org/jira/browse/YARN-4830
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-4830-YARN-3926.001.patch,
> YARN-4830-YARN-3926.002.patch, YARN-4830-YARN-3926.003.patch
>
>
> The RM has support for multiple resource types. The same should be added for
> the NMs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
