[ 
https://issues.apache.org/jira/browse/YARN-5156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311710#comment-15311710
 ] 

Varun Saxena edited comment on YARN-5156 at 6/2/16 4:42 AM:
------------------------------------------------------------

[~sjlee0]
bq. To be clear, this issue already exists in the trunk, right? When I look at 
the trunk code, what it does is no different and thus this issue would exist 
with timeline service v.1.x as well.
In trunk, ApplicationContainerFinishedEvent only captures the container ID 
whereas here we are cloning the container status and sending it. This container 
status is used by NMTimelinePublisher. Regarding ATSv1, we do not publish from 
NM for it so this is an issue specific to our branch. 
This container status is what is leading to reporting of RUNNING as the state 
machine transition in ContainerImpl is not yet complete. 

Saw Vrushali posted a patch. Will have a look at it.


was (Author: varun_saxena):
[~sjlee0]
bq. To be clear, this issue already exists in the trunk, right? When I look at 
the trunk code, what it does is no different and thus this issue would exist 
with timeline service v.1.x as well.
In trunk, ApplicationContainerFinishedEvent only captures the container ID 
whereas here we are cloning the container status and sending it. This container 
status is used by NMTimelinePublisher. Regarding ATSv1, we do not publish from 
NM for it so this is an issue specific to our branch. 
This container status is what is leading to reporting of RUNNING as the state 
machine transition in ContainerImpl is not yet complete. Will look at 
Vrushali's patch.

> YARN_CONTAINER_FINISHED of YARN_CONTAINERs will always have running state
> -------------------------------------------------------------------------
>
>                 Key: YARN-5156
>                 URL: https://issues.apache.org/jira/browse/YARN-5156
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Li Lu
>            Assignee: Vrushali C
>         Attachments: YARN-5156-YARN-2928.01.patch
>
>
> On container finished, we're reporting "YARN_CONTAINER_STATE: "RUNNING"". Do 
> we design this deliberately or it's a bug? 
> {code}
> {
> metrics: [ ],
> events: [
> {
> id: "YARN_CONTAINER_FINISHED",
> timestamp: 1464213765890,
> info: {
> YARN_CONTAINER_EXIT_STATUS: 0,
> YARN_CONTAINER_STATE: "RUNNING",
> YARN_CONTAINER_DIAGNOSTICS_INFO: ""
> }
> },
> {
> id: "YARN_NM_CONTAINER_LOCALIZATION_FINISHED",
> timestamp: 1464213761133,
> info: { }
> },
> {
> id: "YARN_CONTAINER_CREATED",
> timestamp: 1464213761132,
> info: { }
> },
> {
> id: "YARN_NM_CONTAINER_LOCALIZATION_STARTED",
> timestamp: 1464213761132,
> info: { }
> }
> ],
> id: "container_e15_1464213707405_0001_01_000018",
> type: "YARN_CONTAINER",
> createdtime: 1464213761132,
> info: {
> YARN_CONTAINER_ALLOCATED_PRIORITY: "20",
> YARN_CONTAINER_ALLOCATED_VCORE: 1,
> YARN_CONTAINER_ALLOCATED_HOST_HTTP_ADDRESS: "10.22.16.164:0",
> UID: 
> "yarn_cluster!application_1464213707405_0001!YARN_CONTAINER!container_e15_1464213707405_0001_01_000018",
> YARN_CONTAINER_ALLOCATED_HOST: "10.22.16.164",
> YARN_CONTAINER_ALLOCATED_MEMORY: 1024,
> SYSTEM_INFO_PARENT_ENTITY: {
> type: "YARN_APPLICATION_ATTEMPT",
> id: "appattempt_1464213707405_0001_000001"
> },
> YARN_CONTAINER_ALLOCATED_PORT: 64694
> },
> configs: { },
> isrelatedto: { },
> relatesto: { }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to