[ 
https://issues.apache.org/jira/browse/YARN-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15312630#comment-15312630
 ] 

Arun Suresh commented on YARN-5171:
-----------------------------------

[~elgoiri], I don't think you are decrementing 
{{attemptResourceUsageOpportunistic}} when the OPPORTUNISTIC container 
completes.
I guess we would should also have to remove it from the 
SchedulerApplicationAttempts's liveContainers list. You can do this in the 
{{completedContainer()}} method in your if check like so:

{noformat}
   if (!rmContainer.isExternallyAllocated()) {
      completedContainerInternal(rmContainer, containerStatus, event);
    } else {
      // get the SchedulerApplicationAttempt
      // remove from the appAttempts liveContainers
      // decrement the appAttempts attemptResourceUsageOpportunistic
    }
{noformat}

Makes sense ?

> Extend DistributedSchedulerProtocol to notify RM of containers allocated by 
> the Node
> ------------------------------------------------------------------------------------
>
>                 Key: YARN-5171
>                 URL: https://issues.apache.org/jira/browse/YARN-5171
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Arun Suresh
>            Assignee: Inigo Goiri
>         Attachments: YARN-5171.000.patch, YARN-5171.001.patch, 
> YARN-5171.002.patch, YARN-5171.003.patch
>
>
> Currently, the RM does not know about Containers allocated by the 
> OpportunisticContainerAllocator on the NM. This JIRA proposes to extend the 
> Distributed Scheduler request interceptor and the protocol to notify the RM 
> of new containers as and when they are allocated at the NM. The 
> {{RMContainer}} should also be extended to expose the {{ExecutionType}} of 
> the container.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to