[
https://issues.apache.org/jira/browse/YARN-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314340#comment-15314340
]
Daniel Templeton commented on YARN-4996:
----------------------------------------
Thanks, [~lewuathe]. Looks like there's still an unused import to clean up.
(See checkstyle.) Also, one small issue with the {{getScheduler()}} javadocs.
The first sentence in the javadoc should be the method summary, as it will be
used as the oneliner for the method in the doc page for the class. You should
probably also mention that the scheduler is created by the \{@link
#configureScheduler()\} method.
> Make TestNMReconnect.testCompareRMNodeAfterReconnect() scheduler agnostic, or
> better yet parameterized
> ------------------------------------------------------------------------------------------------------
>
> Key: YARN-4996
> URL: https://issues.apache.org/jira/browse/YARN-4996
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager, test
> Affects Versions: 2.8.0
> Reporter: Daniel Templeton
> Assignee: Kai Sasaki
> Priority: Minor
> Labels: newbie
> Attachments: YARN-4996.01.patch, YARN-4996.02.patch,
> YARN-4996.03.patch, YARN-4996.04.patch, YARN-4996.05.patch, YARN-4996.06.patch
>
>
> The test tests only the capacity scheduler. It should also test fair
> scheduler. At a bare minimum, it should use the default scheduler.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
