[
https://issues.apache.org/jira/browse/YARN-4830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318694#comment-15318694
]
Arun Suresh commented on YARN-4830:
-----------------------------------
[~vvasudev], apologize for the delay... thanks for addressing my comments.
W.r.t using a nodeLock object vs. a volatile boolean, I still feel it might be
cleaner to use the boolean, but given that it conforms to the existing style in
the class (using 'lock' and 'readOnlyResources'), am willing to go with it.
Also, don't think we would be losing out on too many of the JVM optimizations
by making 'readOnlyNodeResources' volatile, since its just a reference check,
and chances are it gets checked mostly during the
{{ResourceUtils.getNodeResourceInformation(}}} which I think occurs not too
frequently.. But like i said above, am willing to go with it.
+! for the latest patch, pending the 2 fixable checkstyles.
> Add support for resource types in the nodemanager
> -------------------------------------------------
>
> Key: YARN-4830
> URL: https://issues.apache.org/jira/browse/YARN-4830
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-4830-YARN-3926.001.patch,
> YARN-4830-YARN-3926.002.patch, YARN-4830-YARN-3926.003.patch,
> YARN-4830-YARN-3926.004.patch
>
>
> The RM has support for multiple resource types. The same should be added for
> the NMs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
