[
https://issues.apache.org/jira/browse/YARN-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323923#comment-15323923
]
Sunil G commented on YARN-5153:
-------------------------------
Thanks [~leftnoteasy] for the patch and screen shots:
Few comments
1. User has to click on one container/app attempt from the below table to see
the time line view at the top of the page, Am I correct?. If so, is it better
to keep the table at the top and we can show the timeline view below table. We
can fix the size of the table for this. Or did you see some other advantages
for keeping the timeline view at the top?
2. If containers life time is lesser, we are going to see more active table for
listing containers. If one container is finished and if the entry is still
present in table, we may show more error logs. Do you prefer to keep a
*Refresh* button?
3.
in {{containers-table arr1=rmModel arr2=tsModel
table-id="app-attempts-table"}}, could we name
arr1 -> rmContainers
arr2 -> timelineContainers
for better readability.
4. In {{yarn-app-attempt.hbs}}
{code}
+ {{timeline-view parent-id="containers-timeline-div"
my-id="timeline-view" height="400" rmModel=model.rmContainers
tsModel=model.tsContainers
+ label="shortAppAttemptId" attemptModel=false
timelineView=isTimelineView}}
{code}
I think {{timelineView}} is no longer used.
> [YARN-3368] Add a toggle to switch timeline view / table view for containers
> information inside application-attempt page
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-5153
> URL: https://issues.apache.org/jira/browse/YARN-5153
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-5153-YARN-3368.1.patch,
> YARN-5153.preliminary.1.patch, screenshot-1.png, screenshot-2.png,
> screenshot-3.png, screenshot-4.png, screenshot-5.png
>
>
> Now we only support timeline view for containers on app-attempt page, it will
> be also very useful to show table of containers in some cases. For example,
> user can short containers based on priority, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
