[
https://issues.apache.org/jira/browse/YARN-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323942#comment-15323942
]
Sunil G commented on YARN-5161:
-------------------------------
Hi [~kaisasak]
Thanks for updating patch. Few quick comments.
Since this patch contains a binary file, I cannot apply it with {{patch -p0 -i
<patch-name>}} as it skips binary file. Some how this patch cannot be applied
with "git apply" command. Seems patch is not generated by using "format-patch".
And we can apply binary patches using {{git apply --binary <patch_file>}}. So
could you please regenerate patch by using git format-patch command. May be I
am missing something or some command line option. pls feel free to correct me
if I am missing something. :)
*Few other nits:*
1. I think we can change the color scheme of UI links. Since hadoop logo is
more blueish color, we can change the top level links color to a closer color
tone to hadoop logo. It may make UI more unique in color tone. What do you
think?
2. I feel alternate text can be "Apache Hadoop". I feel we can skip YARN.
{{alt="Apache Hadoop"}}
> [YARN-3368] Add Apache Hadoop logo to UI home page
> --------------------------------------------------
>
> Key: YARN-5161
> URL: https://issues.apache.org/jira/browse/YARN-5161
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: webapp
> Reporter: Sunil G
> Assignee: Kai Sasaki
> Attachments: Screen Shot 2016-05-31 at 21.22.30.png,
> YARN-5161-YARN-3368.03.patch, YARN-5161.01.patch, YARN-5161.02.patch,
> apache_logo.png, hadoop_logo.png
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
