[ 
https://issues.apache.org/jira/browse/YARN-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327386#comment-15327386
 ] 

Sunil G commented on YARN-5130:
-------------------------------

Thanks [~GergelyNovak].

Given the discussion went in yarn-dev mailing list, I guess this looks fine. 
However, I think we can also make some changes to the newly added abstract 
methods in NodeReport and ContainerStatus by providing a base implementation 
too. Do we need to go inthis line? [~steve_l] Thoughts?  cc/[~leftnoteasy]

> Mark ContainerStatus and NodeReport as evolving
> -----------------------------------------------
>
>                 Key: YARN-5130
>                 URL: https://issues.apache.org/jira/browse/YARN-5130
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: yarn
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Assignee: Gergely Novák
>            Priority: Minor
>         Attachments: YARN-5130.001.patch
>
>
> It turns out that slider won't build as the {{ContainerStatus}} and 
> {{NodeReport}} classes have added more abstract methods, so breaking the mock 
> objects.
> While it is everyone's freedom to change things, these classes are both tagged
> {code}
> @Public
> @Stable
> {code}
> Given they aren't stable, can someone mark them as {{@Evolving}}? That way 
> when downstream code breaks, we can be less disappointed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to