[ https://issues.apache.org/jira/browse/YARN-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329892#comment-15329892 ]
Joep Rottinghuis commented on YARN-5070: ---------------------------------------- Thanks [~vrushalic] patch 05 looks good to me. There are a few items that we could improve upon, but those aren't introduced in this patch, so we should tackle them in a separate jira: * Line 261 " + FlowRunRowKey.parseRowKey(cells.get(0).getRow()).toString());" uses a deprecated method. * Line 208 has @SuppressWarnings("deprecation"). Is that really needed? * you already left a TODO, which we can tackle separately as well. > upgrade HBase version for first merge > ------------------------------------- > > Key: YARN-5070 > URL: https://issues.apache.org/jira/browse/YARN-5070 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver > Affects Versions: YARN-2928 > Reporter: Sangjin Lee > Assignee: Vrushali C > Priority: Critical > Labels: yarn-2928-1st-milestone > Attachments: YARN-5070-YARN-2928.01.patch, > YARN-5070-YARN-2928.02.patch, YARN-5070-YARN-2928.03.patch, > YARN-5070-YARN-2928.04.patch, YARN-5070-YARN-2928.05.patch > > > Currently we set the HBase version for the timeline service storage to 1.0.1. > This is a fairly old version, and there are reasons to upgrade to a newer > version. We should upgrade it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org