[ 
https://issues.apache.org/jira/browse/YARN-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330212#comment-15330212
 ] 

Varun Saxena commented on YARN-5243:
------------------------------------

[~sjlee0], thanks for the patch. The patch looks good.
However, there are a bunch of unused/duplicate imports too in 
{{ResourceManager.java}}. Probably introduced during rebase. This can be fixed 
here as well. 

> fix several rebase and other miscellaneous issues before merge
> --------------------------------------------------------------
>
>                 Key: YARN-5243
>                 URL: https://issues.apache.org/jira/browse/YARN-5243
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-5243-YARN-2928.01.patch, 
> YARN-5243-YARN-2928.02.patch
>
>
> I have come across a couple of miscellaneous issues while inspecting the 
> diffs against the trunk.
> We also need to review one last time (probably after the final rebase) to 
> ensure the timeline services v.2 leaves no impact when disabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to