[ 
https://issues.apache.org/jira/browse/YARN-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335043#comment-15335043
 ] 

Arun Suresh commented on YARN-5221:
-----------------------------------

Thanks for the review [~leftnoteasy]

bq. How to handle container version mismatch issue or other issues which cause 
update failure?
In the patch, the checking is done in the {{ApplicationMasterService}} and it 
just logs the mismatch. I agree, let me update the {{AllocateResponse}} to 
include something like failed update requests (with a message giving the reason)

bq. org.apache.hadoop.yarn.server.resourcemanager.scheduler.Allocation: should 
we merge increase/decrease container list ?
We could, but since that is not part of the API per se I was thinking that 
maybe its fine as it is.. we can probably file a follow-up JIRA

I agree with the rest of your comments... will update the patch shortly 
addressing them.

> Expose UpdateResourceRequest API to allow AM to request for change in 
> container properties
> ------------------------------------------------------------------------------------------
>
>                 Key: YARN-5221
>                 URL: https://issues.apache.org/jira/browse/YARN-5221
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: YARN-5221.001.patch, YARN-5221.002.patch, 
> YARN-5221.003.patch, YARN-5221.004.patch
>
>
> YARN-1197 introduced APIs to allow an AM to request for Increase and Decrease 
> of Container Resources after initial allocation.
> YARN-5085 proposes to allow an AM to request for a change of Container 
> ExecutionType.
> This JIRA proposes to unify both of the above into an Update Container API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to