[
https://issues.apache.org/jira/browse/YARN-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337390#comment-15337390
]
Konstantinos Karanasos edited comment on YARN-5171 at 6/18/16 1:32 AM:
-----------------------------------------------------------------------
bq. Keep the two new methods, but refactor the code, so that everybody (i.e.,
the existing guranteed containers too) is using these methods when
adding/removing RMContainers.
I just had a chat with [~elgoiri] and [~subru] regarding this... We have two
options:
# As I suggested above, we refactor other parts of the code to use the same
add/removeRMContainer methods.
# We rename the methods {{addRMContainer}} and {{removeRMContainer}} to
{{addExternalRMContainer}} and {{removeExternalRMContainer}}, respectively, and
we do no other changes.
Solution (2) is simpler. While solution (1) seems cleaner, it is not clear how
easy the refactoring will be, and if it deserves a separate JIRA.
[~jianhe], by doing a git blame, it shows that you have extensively worked on
this class. What would you suggest?
was (Author: kkaranasos):
bq. Keep the two new methods, but refactor the code, so that everybody (i.e.,
the existing guranteed containers too) is using these methods when
adding/removing RMContainers.
I just had a chat with [~elgoiri] and [~subru] regarding this... We have two
options:
# As I suggested above, we refactor other parts of the code to use the same
add/removeRMContainer methods.
# We rename the methods {{addRMContainer}} and {{removeRMContainer}} to
{{addExternalRMContainer}} and {{removeExternalRMContainer}}, respectively, and
we do no other changes.
Solution (1) is simpler. While solution (2) seems cleaner, it is not clear how
easy the refactoring will be, and if it deserves a separate JIRA.
[~jianhe], by doing a git blame, it shows that you have extensively worked on
this class. What would you suggest?
> Extend DistributedSchedulerProtocol to notify RM of containers allocated by
> the Node
> ------------------------------------------------------------------------------------
>
> Key: YARN-5171
> URL: https://issues.apache.org/jira/browse/YARN-5171
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: Inigo Goiri
> Attachments: YARN-5171.000.patch, YARN-5171.001.patch,
> YARN-5171.002.patch, YARN-5171.003.patch, YARN-5171.004.patch,
> YARN-5171.005.patch, YARN-5171.006.patch
>
>
> Currently, the RM does not know about Containers allocated by the
> OpportunisticContainerAllocator on the NM. This JIRA proposes to extend the
> Distributed Scheduler request interceptor and the protocol to notify the RM
> of new containers as and when they are allocated at the NM. The
> {{RMContainer}} should also be extended to expose the {{ExecutionType}} of
> the container.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
